feat: Add 'PermissionManager' module by NicolasBourdin88 · Pull Request #745 · Infomaniak/android-core

NicolasBourdin88 · 2026-04-15T13:06:18Z

Add a 'PermissionManager' that allow you to easily manage permission across your application.

Depends on #738

github-actions · 2026-04-15T13:07:58Z

PR Reviewer Guide 🔍

(Review updated until commit `d8bb9c7`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Coroutine Leak In `waitUntilGranted`, when `status.isGranted` is already true, the returned lambda executes `action()` immediately but never completes the `actionFired` job. This leaves the `LaunchedEffect` suspended indefinitely at `actionFired.join()`, causing a coroutine leak every time this code path is taken (e.g., when a user triggers an action while the permission is already granted). return fun() { if (status.isGranted) { action() } else { launchPermissionRequest() actionFired.complete() } } Missing Remember Keys The `remember` call on line 38 lacks keys. If `permissionState` or `shouldDisplayRationale` references change (e.g., during recomposition with different inputs), the stale remembered instance will be used. Add `remember(permissionState, shouldDisplayRationale)` to ensure correctness. remember { SupportedApiPermissionManagerState(permissionState, shouldDisplayRationale) }

sirambd

We need to support required permissions as well

github-actions · 2026-04-16T06:12:56Z

Persistent review updated to latest commit 830a2eb

github-actions · 2026-04-16T06:40:19Z

Persistent review updated to latest commit fdc6f09

github-actions · 2026-04-16T08:54:55Z

Persistent review updated to latest commit 1678945

github-actions · 2026-04-16T09:07:41Z

Persistent review updated to latest commit 6d914f3

github-actions · 2026-04-16T14:13:30Z

Persistent review updated to latest commit d8bb9c7

Copilot

Pull request overview

Adds a new PermissionManager Android library module intended to centralize permission handling via Jetpack Compose + Accompanist, and wires it into the multi-module build.

Changes:

Registers the new :PermissionManager Gradle module and publishes a new version-catalog alias for it.
Introduces a Compose-first PermissionManagerState API with supported/unsupported-API implementations.
Adds accompanist-permissions to the version catalog and uses it in the new module.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
settings.gradle.kts	Includes the new `:PermissionManager` module in the build.
gradle/core.versions.toml	Adds Accompanist permissions dependency + a new `infomaniak-core-permissionmanager` catalog entry.
PermissionManager/build.gradle.kts	New Android library module configuration and dependencies (Compose + Accompanist).
PermissionManager/src/main/kotlin/com/infomaniak/core/permissionmanager/PermissionManagerState.kt	Public `rememberPermissionManagerState` entry point + `PermissionManagerState` API.
PermissionManager/src/main/kotlin/com/infomaniak/core/permissionmanager/SupportedApiPermissionManagerState.kt	Supported-permission implementation backed by Accompanist `PermissionState`.
PermissionManager/src/main/kotlin/com/infomaniak/core/permissionmanager/UnsupportedApiPermissionManagerState.kt	No-op implementation for permissions not applicable on the current API level.
PermissionManager/src/main/kotlin/com/infomaniak/core/permissionmanager/PermissionType.kt	Adds `PermissionType` enum mapping app concepts to Android permission strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-22T11:30:44Z